Add zone support for Dyson 360 Heurist #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
==========================================
- Coverage 97.65% 96.53% -1.13%
==========================================
Files 21 22 +1
Lines 940 981 +41
==========================================
+ Hits 918 947 +29
- Misses 22 34 +12
Continue to review full report at Codecov.
|
shenxn
reviewed
May 23, 2021
| @@ -3,3 +3,4 @@ cryptography>=3.1 | |||
| requests | |||
| zeroconf | |||
| attrs | |||
| python-dateutil | |||
There was a problem hiding this comment.
Please add this to setup.py as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for zones to the Dyson 360 Heurist - #8
Zones are defined in the Dyson Link app and (unfortunately) stored on Dyson servers. You need to call the Dyson API to get a
PersistentMap. Then to tell the Heurist to clean a specific zone, you must pass in the id and last updated date of the map, along with the zone ids to be cleaned. This is made easier by thestart_zonesmethod which allows you to specify zones by name.Example:
I tested this with my Heurist and it works. To see if I could clean a zone without internet, I disabled my internet but left Wifi turned on and opened the Dyson Link app. I could start a full clean but everything related to Zones were disabled. I could not see, edit, or clean any zones. I snooped the MQTT messages to see if the map data is passed anywhere, but unfortunately it is not. This will make integration with HA more difficult.